diff mercurial/hbisect.py @ 15057:774da7121fc9

atomictempfile: make close() consistent with other file-like objects.

The usual contract is that close() makes your writes permanent, so
atomictempfile's use of close() to *discard* writes (and rename() to
keep them) is rather unexpected. Thus, change it so close() makes
things permanent and add a new discard() method to throw them away.
discard() is only used internally, in __del__(), to ensure that writes
are discarded when an atomictempfile object goes out of scope.

I audited mercurial.*, hgext.*, and ~80 third-party extensions, and
found no one using the existing semantics of close() to discard
writes, so this should be safe.

--- a/mercurial/hbisect.py	Wed Aug 24 05:42:41 2011 -0400
+++ b/mercurial/hbisect.py	Thu Aug 25 20:21:04 2011 -0400
@@ -150,7 +150,7 @@
         for kind in state:
             for node in state[kind]:
                 f.write("%s %s\n" % (kind, hex(node)))
-        f.rename()
+        f.close()
     finally:
         wlock.release()