Mercurial > hg
diff hgext/highlight/highlight.py @ 26680:7a3f6490ef97
highlight: add option to prevent content-only based fallback
When Mozilla enabled Pygments on hg.mozilla.org, we got a lot of weirdly
colorized files. Upon further investigation, the hightlight extension
is first attempting a filename+content based match then falling back to a
purely content-driven detection mode in Pygments. Sounds good in theory.
Unfortunately, Pygments' content-driven detection establishes no minimum
threshold for returning a lexer. Furthermore, the detection code for
a number of languages is very liberal. For example, ActionScript 3 will
return a confidence of 0.3 (out of 1.0) if the first 1k of the file
we pass in matches the regex "\w+\s*:\s*\w"! Python matches on
"import ". It's no coincidence that a number of our extension-less files
were getting highlighted improperly.
This patch adds an option to have the highlighter not fall back to
purely content-based detection when filename+content detection failed.
This can be enabled to render unlighted text instead of taking the risk
that unknown file types are highlighted incorrectly. The old behavior is
still the default.
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Wed, 14 Oct 2015 18:22:16 -0700 |
parents | c35ee1bbbbdc |
children | b502138f5faa |
line wrap: on
line diff
--- a/hgext/highlight/highlight.py Wed Oct 14 17:43:44 2015 -0700 +++ b/hgext/highlight/highlight.py Wed Oct 14 18:22:16 2015 -0700 @@ -20,7 +20,7 @@ SYNTAX_CSS = ('\n<link rel="stylesheet" href="{url}highlightcss" ' 'type="text/css" />') -def pygmentize(field, fctx, style, tmpl): +def pygmentize(field, fctx, style, tmpl, guessfilenameonly=False): # append a <link ...> to the syntax highlighting css old_header = tmpl.load('header') @@ -46,6 +46,12 @@ lexer = guess_lexer_for_filename(fctx.path(), text[:1024], stripnl=False) except (ClassNotFound, ValueError): + # guess_lexer will return a lexer if *any* lexer matches. There is + # no way to specify a minimum match score. This can give a high rate of + # false positives on files with an unknown filename pattern. + if guessfilenameonly: + return + try: lexer = guess_lexer(text[:1024], stripnl=False) except (ClassNotFound, ValueError):