Mercurial > hg
diff tests/test-check-code @ 11341:920a783e5f91
check-code: fix check for any/all function
The old check would only detect any/all at the beginning of a line.
The regexp was probably just modeled after the preceding regexp which
(correctly) finds the 'with' keyword at the beginning of a line.
We now complain about 'any(' and 'all(' anywhere in a line, unless it
is preceded by 'def'. This allows us to define our own compatibility
wrapper in util and use 'util.any(' in the code.
author | Martin Geisler <mg@aragost.com> |
---|---|
date | Tue, 15 Jun 2010 09:51:52 +0200 |
parents | 62b8f15683f2 |
children | f325db39c8b9 |
line wrap: on
line diff
--- a/tests/test-check-code Mon Jun 14 16:56:20 2010 -0300 +++ b/tests/test-check-code Tue Jun 15 09:51:52 2010 +0200 @@ -22,5 +22,15 @@ a, '\\\\\\\\', "\\\\\\" x-2", "c-1" EOF +cat > non-py24.py <<EOF +# Using builtins that does not exist in Python 2.4 +if any(): + x = all() + +# Do not complain about our own definition +def any(x): + pass +EOF + check_code=`dirname $0`/../contrib/check-code.py -${check_code} ./wrong.py ./correct.py ./quote.py +${check_code} ./wrong.py ./correct.py ./quote.py ./non-py24.py