diff tests/test-lfs.t @ 49534:92892dff03f3

revlog: use the user facing filename as the display_id for filelogs

I had trouble isolating some LFS blob corruption detected by `hg verify` because
the traceback referenced a file, but with the `data/` prefix in the `.hg/store`
path, so it couldn't be located with the `file()` revset:

```
    Traceback (most recent call last):
      File "/mnt/d/mercurial/mercurial/revlog.py", line 3209, in verifyintegrity
        _verify_revision(self, skipflags, state, node)
      File "/mnt/d/mercurial/hgext/lfs/wrapper.py", line 246, in _verify_revision
        orig(rl, skipflags, state, node)
      File "/mnt/d/mercurial/mercurial/revlog.py", line 158, in _verify_revision
        rl.revision(node)
      File "/mnt/d/mercurial/mercurial/revlog.py", line 1816, in revision
        return self._revisiondata(nodeorrev, _df)
      File "/mnt/d/mercurial/mercurial/revlog.py", line 1870, in _revisiondata
        self.checkhash(text, node, rev=rev)
      File "/mnt/d/mercurial/mercurial/revlog.py", line 1996, in checkhash
        % (self.display_id, pycompat.bytestr(revornode))
    mercurial.error.RevlogError: integrity check failed on data/EXE/PPC/shrinksrec.exe:0
```

(I'm a little surprised it resulted in a stacktrace instead of just a message,
but that's a different issue.  I'm also not sure how to trigger the simplestore
case, since IIUC, it's also a revlog based store.)

It's not clear how to handle the changelog and manifest (because the user
doesn't interact with them as a file), so those cases are left alone.  The other
thing that would be nice to improve somehow is to indicate that the ":0" is a
revlog revision, not the changeset revision that users are used to.  I'm not
sure how to handle the "or node" part though.

--- a/tests/test-lfs.t	Wed Oct 19 11:24:20 2022 -0400
+++ b/tests/test-lfs.t	Wed Oct 19 11:50:40 2022 -0400
@@ -787,8 +787,8 @@
   checking manifests
   crosschecking files in changesets and manifests
   checking files
-   l@1: unpacking 46a2f24864bc: integrity check failed on data/l:0
-   large@0: unpacking 2c531e0992ff: integrity check failed on data/large:0
+   l@1: unpacking 46a2f24864bc: integrity check failed on l:0
+   large@0: unpacking 2c531e0992ff: integrity check failed on large:0
   checked 5 changesets with 10 changes to 4 files
   2 integrity errors encountered!
   (first damaged changeset appears to be 0)
@@ -897,9 +897,9 @@
   checking manifests
   crosschecking files in changesets and manifests
   checking files
-   l@1: unpacking 46a2f24864bc: integrity check failed on data/l:0
+   l@1: unpacking 46a2f24864bc: integrity check failed on l:0
   lfs: found 22f66a3fc0b9bf3f012c814303995ec07099b3a9ce02a7af84b5970811074a3b in the local lfs store
-   large@0: unpacking 2c531e0992ff: integrity check failed on data/large:0
+   large@0: unpacking 2c531e0992ff: integrity check failed on large:0
   lfs: found 89b6070915a3d573ff3599d1cda305bc5e38549b15c4847ab034169da66e1ca8 in the local lfs store
   lfs: found b1a6ea88da0017a0e77db139a54618986e9a2489bee24af9fe596de9daac498c in the local lfs store
   checked 5 changesets with 10 changes to 4 files
@@ -941,8 +941,8 @@
   checking manifests
   crosschecking files in changesets and manifests
   checking files
-   l@1: unpacking 46a2f24864bc: integrity check failed on data/l:0
-   large@0: unpacking 2c531e0992ff: integrity check failed on data/large:0
+   l@1: unpacking 46a2f24864bc: integrity check failed on l:0
+   large@0: unpacking 2c531e0992ff: integrity check failed on large:0
   checked 5 changesets with 10 changes to 4 files
   2 integrity errors encountered!
   (first damaged changeset appears to be 0)
@@ -967,9 +967,9 @@
   checking manifests
   crosschecking files in changesets and manifests
   checking files
-   l@1: unpacking 46a2f24864bc: integrity check failed on data/l:0
+   l@1: unpacking 46a2f24864bc: integrity check failed on l:0
   lfs: found 22f66a3fc0b9bf3f012c814303995ec07099b3a9ce02a7af84b5970811074a3b in the local lfs store
-   large@0: unpacking 2c531e0992ff: integrity check failed on data/large:0
+   large@0: unpacking 2c531e0992ff: integrity check failed on large:0
   lfs: found 89b6070915a3d573ff3599d1cda305bc5e38549b15c4847ab034169da66e1ca8 in the local lfs store
   lfs: found b1a6ea88da0017a0e77db139a54618986e9a2489bee24af9fe596de9daac498c in the local lfs store
   checked 5 changesets with 10 changes to 4 files
@@ -987,7 +987,7 @@
 Accessing a corrupt file will complain
 
   $ hg --cwd fromcorrupt2 cat -r 0 large
-  abort: integrity check failed on data/large:0
+  abort: integrity check failed on large:0
   [50]
 
 lfs -> normal -> lfs round trip conversions are possible.  The 'none()'