Mercurial > hg
diff hgext/remotefilelog/shallowutil.py @ 41140:92a5fb73b3d5
remotefilelog: add newlines to ui.log() invocations
The comment at the top of ui.log() says that the message should be a
newline-terminated string. When using the blackbox logger, if the string does
not end in a newline, the appearance in the file gets quite messy.
This sometimes leaves a string with just the newline as the message, these are
logged by the blackbox logger just fine. I don't know what other loggers do when
logging structured data and a message that is just the newline.
Differential Revision: https://phab.mercurial-scm.org/D5533
author | Kyle Lippincott <spectral@google.com> |
---|---|
date | Tue, 08 Jan 2019 14:48:05 -0800 |
parents | 3fa4183e7803 |
children | d08c816a11d3 |
line wrap: on
line diff
--- a/hgext/remotefilelog/shallowutil.py Tue Jan 08 10:31:10 2019 -0500 +++ b/hgext/remotefilelog/shallowutil.py Tue Jan 08 14:48:05 2019 -0800 @@ -106,7 +106,7 @@ def reportpackmetrics(ui, prefix, *stores): dicts = [s.getmetrics() for s in stores] dict = prefixkeys(sumdicts(*dicts), prefix + '_') - ui.log(prefix + "_packsizes", "", **pycompat.strkwargs(dict)) + ui.log(prefix + "_packsizes", "\n", **pycompat.strkwargs(dict)) def _parsepackmeta(metabuf): """parse datapack meta, bytes (<metadata-list>) -> dict