diff mercurial/hgweb/hgweb_mod.py @ 7180:a42d27bc809d

hgweb: be sure to drain request data even in early error conditions

Thanks to Mads Kiilerich with noticing this. The hg client can only read data
after all the sent data has been read, so we have to read all the request data
even if we're not going to do anything with it (in error conditions). This
is not easy to fix in the client, because we're using Python's httplib, which
is strictly stateful. Abstracted the draining into a separate method.

--- a/mercurial/hgweb/hgweb_mod.py	Sun Oct 19 22:07:43 2008 +0200
+++ b/mercurial/hgweb/hgweb_mod.py	Mon Oct 20 10:15:26 2008 +0200
@@ -91,7 +91,12 @@
         if cmd and cmd in protocol.__all__:
             try:
                 if cmd in perms:
-                    self.check_perm(req, perms[cmd])
+                    try:
+                        self.check_perm(req, perms[cmd])
+                    except ErrorResponse, inst:
+                        if cmd == 'unbundle':
+                            req.drain()
+                        raise
                 method = getattr(protocol, cmd)
                 return method(self.repo, req)
             except ErrorResponse, inst: