diff mercurial/revset.py @ 46663:a4c19a162615

sshpeer: enable+fix warning about sshpeers not being closed explicitly

I recommend looking at this with a diff that ignores indentation.

The test changes are because localrepo.close() updates some cache,
which appears happens earlier now on rollbacks or strips or something.

The http changes are because httppeer.close() prints stats with
--verbose.

Differential Revision: https://phab.mercurial-scm.org/D9999

--- a/mercurial/revset.py	Mon Feb 15 14:40:17 2021 -0500
+++ b/mercurial/revset.py	Mon Feb 15 14:48:36 2021 -0500
@@ -1841,9 +1841,12 @@
     if revs:
         revs = [repo.lookup(rev) for rev in revs]
     other = hg.peer(repo, {}, dest)
-    repo.ui.pushbuffer()
-    outgoing = discovery.findcommonoutgoing(repo, other, onlyheads=revs)
-    repo.ui.popbuffer()
+    try:
+        repo.ui.pushbuffer()
+        outgoing = discovery.findcommonoutgoing(repo, other, onlyheads=revs)
+        repo.ui.popbuffer()
+    finally:
+        other.close()
     cl = repo.changelog
     o = {cl.rev(r) for r in outgoing.missing}
     return subset & o