diff mercurial/changegroup.py @ 39241:aad4b46e89bb

manifest: remove addgroup() from manifestlog and imanifestlog

addgroup() is part of the storage interface for manifests.
Unfortunately, we don't yet have a formal storage interface
for manifests. (One will be established in subsequent commits.)

One thing is for sure, addgroup() doesn't belong on imanifestlog -
at least not unless we extend that interface to encompass storage.

For now, let's access addgroup() on the _revlog attribute, just like
we do for tree manifests. Even though this violates visibility,
it is consistent.

Differential Revision: https://phab.mercurial-scm.org/D4274

--- a/mercurial/changegroup.py	Fri Aug 10 13:59:27 2018 -0700
+++ b/mercurial/changegroup.py	Fri Aug 10 14:20:47 2018 -0700
@@ -253,7 +253,8 @@
         # be empty during the pull
         self.manifestheader()
         deltas = self.deltaiter()
-        repo.manifestlog.addgroup(deltas, revmap, trp)
+        # TODO this violates storage abstraction.
+        repo.manifestlog._revlog.addgroup(deltas, revmap, trp)
         prog.complete()
         self.callback = None