Mercurial > hg
diff mercurial/manifest.py @ 39241:aad4b46e89bb
manifest: remove addgroup() from manifestlog and imanifestlog
addgroup() is part of the storage interface for manifests.
Unfortunately, we don't yet have a formal storage interface
for manifests. (One will be established in subsequent commits.)
One thing is for sure, addgroup() doesn't belong on imanifestlog -
at least not unless we extend that interface to encompass storage.
For now, let's access addgroup() on the _revlog attribute, just like
we do for tree manifests. Even though this violates visibility,
it is consistent.
Differential Revision: https://phab.mercurial-scm.org/D4274
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Fri, 10 Aug 2018 14:20:47 -0700 |
parents | 43387fd2aa1f |
children | 1347bcf52d51 |
line wrap: on
line diff
--- a/mercurial/manifest.py Fri Aug 10 13:59:27 2018 -0700 +++ b/mercurial/manifest.py Fri Aug 10 14:20:47 2018 -0700 @@ -1485,9 +1485,6 @@ def rev(self, node): return self._revlog.rev(node) - def addgroup(self, deltas, linkmapper, transaction): - return self._revlog.addgroup(deltas, linkmapper, transaction) - @interfaceutil.implementer(repository.imanifestrevisionwritable) class memmanifestctx(object): def __init__(self, manifestlog):