diff hgext/lfs/wrapper.py @ 39389:b26350d9d7b5

lfs: use a context manager to control the progress bar lifetime
author Matt Harbison <matt_harbison@yahoo.com>
date Sat, 25 Aug 2018 12:41:58 -0400
parents 37e56607cbb9
children d3d4b4b5f725
line wrap: on
line diff
--- a/hgext/lfs/wrapper.py	Sat Aug 25 12:26:44 2018 -0400
+++ b/hgext/lfs/wrapper.py	Sat Aug 25 12:41:58 2018 -0400
@@ -344,17 +344,14 @@
     repo.ui.debug('lfs: computing set of blobs to upload\n')
     pointers = {}
 
-    progress = repo.ui.makeprogress(_('lfs search'), _('changesets'), len(revs))
-
-    try:
+    makeprogress = repo.ui.makeprogress
+    with makeprogress(_('lfs search'), _('changesets'), len(revs)) as progress:
         for r in revs:
             ctx = repo[r]
             for p in pointersfromctx(ctx).values():
                 pointers[p.oid()] = p
             progress.increment()
         return sorted(pointers.values())
-    finally:
-        progress.complete()
 
 def pointerfromctx(ctx, f, removed=False):
     """return a pointer for the named file from the given changectx, or None if