contrib/check-code.py
changeset 26348 b80b2ee71a08
parent 25661 20de1ace07a9
child 26588 b3f7516fa50e
--- a/contrib/check-code.py	Thu Sep 24 00:54:30 2015 -0700
+++ b/contrib/check-code.py	Thu Sep 24 00:34:15 2015 -0700
@@ -291,6 +291,8 @@
     (r'os\.path\.join\(.*, *(""|\'\')\)',
      "use pathutil.normasprefix(path) instead of os.path.join(path, '')"),
     (r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),
+    # XXX only catch mutable arguments on the first line of the definition
+    (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
   ],
   # warnings
   [