diff tests/test-phabricator.t @ 44774:c1c922391314 stable

phabricator: ensure that `phabsend` is given a contiguous, linear commit range

Supplying a non-linear range was another orphan factory.  While in theory there
could be a use case for skipping over garbage commits (like adding debugging)
and getting the valuable commits extracted out at the same time as posting a
review, it seems far more likely that specifying a non-linear range is a user
error.  This is another case of issue6045, but predates both 0680b8a1992a and
601ce5392cb0.

Neither the `--no-amend` case nor resubmitting a previously submitted commit
would cause orphans.  But for the sake of simplicity and to keep the parents
tracked on Phabricator in the proper state, ban missing commits unconditionally.

Differential Revision: https://phab.mercurial-scm.org/D8454

--- a/tests/test-phabricator.t	Fri Apr 24 12:37:43 2020 -0700
+++ b/tests/test-phabricator.t	Thu Apr 16 19:05:25 2020 -0400
@@ -589,6 +589,13 @@
   applying patch from D7917
   applying patch from D7918
 
+Phabsend requires a linear range of commits
+
+  $ hg phabsend -r 0+2+3
+  abort: cannot phabsend multiple head revisions: c44b38f24a45
+  (the revisions must form a linear chain)
+  [255]
+
 Validate arguments with --fold
 
   $ hg phabsend --fold -r 1
@@ -597,9 +604,6 @@
   $ hg phabsend --fold --no-amend -r 1::
   abort: cannot fold with --no-amend
   [255]
-  $ hg phabsend --fold -r 0+3
-  abort: cannot fold non-linear revisions
-  [255]
   $ hg phabsend --fold -r 1::
   abort: cannot fold revisions with different DREV values
   [255]