Mercurial > hg

diff contrib/check-code.py @ 18180:c582a71457e5

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: disallow two-argument form of raise Using this old form makes any attempt to port to Python 3 harder, and the new syntax is supported in 2.4 already.
author Augie Fackler <raf@durin42.com>
date Tue, 01 Jan 2013 12:58:21 -0600
parents e440a2c0d944
children e1caaeb5a2ed
line wrap: on
line diff
--- a/contrib/check-code.py	Tue Jan 01 13:25:07 2013 -0600
+++ b/contrib/check-code.py	Tue Jan 01 12:58:21 2013 -0600
@@ -185,6 +185,8 @@
     (r'[^^+=*/!<>&| %-](\s=|=\s)[^= ]',
      "wrong whitespace around ="),
     (r'raise Exception', "don't raise generic exceptions"),
+    (r'raise [^,(]+, (\([^\)]+\)|[^,\(\)]+)$',
+     "don't use old-style two-argument raise, use Exception(message)"),
     (r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),
     (r' [=!]=\s+(True|False|None)',
      "comparison with singleton, use 'is' or 'is not' instead"),