diff mercurial/simplemerge.py @ 48555:c91418480cb0

simplemerge: use 3-way markers if mode=='merge3', ignoring number of labels Before this patch, we use a combination of `mode` and `labels` to decide which marker style to use. That's mostly my own fault because I was the one who added the `mergediff` as a "mode" instead of adding a separate argument for marker style. Still, let's make these arguments more orthogonal by ignoring the number of labels when deciding which marker style to use. This refactoring makes it a little clearer in the simplemerge *extension* that passing more than 2 `--label` arguments changes the marker style. Differential Revision: https://phab.mercurial-scm.org/D11972
author Martin von Zweigbergk <martinvonz@google.com>
date Tue, 14 Dec 2021 13:12:56 -0800
parents 88a45330b290
children ce8c82a5cd65
line wrap: on
line diff
--- a/mercurial/simplemerge.py	Fri Jan 14 10:25:45 2022 -0800
+++ b/mercurial/simplemerge.py	Tue Dec 14 13:12:56 2021 -0800
@@ -506,7 +506,7 @@
             extrakwargs = {
                 'minimize': True,
             }
-            if name_base is not None:
+            if mode == b'merge3':
                 extrakwargs['base_marker'] = b'|||||||'
                 extrakwargs['name_base'] = name_base
                 extrakwargs['minimize'] = False