diff mercurial/wireprotov1peer.py @ 37635:cc8c06835097

wireproto: convert legacy commands to command executor

Calls to the legacy commands "changegroup" and "changegroupsubset" have
been ported to the new command executor interface.

Because we always pass arguments by name and not position, some
inconsistent names throughout the code base have been unified.

As part of this change, we no longer had any remaining callers
of the legacy command methods {between, branches, changegroup,
changegroupsubset}. So, these interfaces/methods have been dropped
from peer interfaces. We still have an interface declaring these
methods. But that interface is implemented on the concrete peer
types and isn't part of the generic peer interface. (The
implementations of the command executor continue to call these
methods.)

The ultimate goal is to remove the per-command methods from the
generic peer interface: the only interface-conforming way to
call a command will be with the new executor API. At some point,
we may want to move the methods outside of the peer classes and
change the executor implementations to not call methods directly
on a peer instance.

Differential Revision: https://phab.mercurial-scm.org/D3273

--- a/mercurial/wireprotov1peer.py	Fri Apr 13 11:10:59 2018 -0700
+++ b/mercurial/wireprotov1peer.py	Fri Apr 13 11:12:19 2018 -0700
@@ -308,7 +308,8 @@
             else:
                 f.set_result(result)
 
-class wirepeer(repository.legacypeer):
[e-mail](repository.ipeerlegacycommands)
+class wirepeer(repository.peer):
     """Client-side interface for communicating with a peer repository.
 
     Methods commonly call wire protocol commands of the same name.
@@ -502,12 +503,12 @@
                 self._abort(error.ResponseError(_("unexpected response:"), d))
         return r
 
-    def changegroup(self, nodes, kind):
+    def changegroup(self, nodes, source):
         n = wireprototypes.encodelist(nodes)
         f = self._callcompressable("changegroup", roots=n)
         return changegroupmod.cg1unpacker(f, 'UN')
 
-    def changegroupsubset(self, bases, heads, kind):
+    def changegroupsubset(self, bases, heads, source):
         self.requirecap('changegroupsubset', _('look up remote changes'))
         bases = wireprototypes.encodelist(bases)
         heads = wireprototypes.encodelist(heads)