Mercurial > hg
diff hgext/phabricator.py @ 44329:d1177d39012e stable
phabricator: fix a phabsend crash when processing a renamed binary
This was a trivial fix, and some more tests are added to cover binary files.
Since the old filecontext is passed in, the old name is still available. But I
noticed some weirdness around what it marked as binary and not, and what is
viewable in Phabricator. Those things have been flagged, and will probably take
some digging.
Differential Revision: https://phab.mercurial-scm.org/D8133
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Tue, 18 Feb 2020 13:46:10 -0500 |
parents | 5d85e9ddc7b9 |
children | adb93aa98c78 |
line wrap: on
line diff
--- a/hgext/phabricator.py Fri Dec 13 10:37:45 2019 +0100 +++ b/hgext/phabricator.py Tue Feb 18 13:46:10 2020 -0500 @@ -892,7 +892,7 @@ if fctx.isbinary() or notutf8(fctx): makebinary(pchange, fctx) if renamed: - addoldbinary(pchange, fctx, originalfname) + addoldbinary(pchange, fctx) else: maketext(pchange, ctx, fname)