diff mercurial/extensions.py @ 14316:d5b525697ddb

extensions: drop maxlength from enabled and disabled

This is a bad/silly API. Instead calculate maxlength in one place in help
it's used and simplify all the callers.

--- a/mercurial/extensions.py	Fri May 13 11:26:29 2011 +0200
+++ b/mercurial/extensions.py	Fri May 13 11:04:51 2011 -0500
@@ -230,20 +230,15 @@
 
     paths = _disabledpaths()
     if not paths:
-        return None, 0
+        return None
 
     exts = {}
-    maxlength = 0
     for name, path in paths.iteritems():
         doc = _disabledhelp(path)
-        if not doc:
-            continue
+        if doc:
+            exts[name] = doc
 
-        exts[name] = doc
-        if len(name) > maxlength:
-            maxlength = len(name)
-
-    return exts, maxlength
+    return exts
 
 def disabledext(name):
     '''find a specific disabled extension from hgext. returns desc'''
@@ -299,11 +294,9 @@
 def enabled():
     '''return a dict of {name: desc} of extensions, and the max name length'''
     exts = {}
-    maxlength = 0
     for ename, ext in extensions():
         doc = (gettext(ext.__doc__) or _('(no help text available)'))
         ename = ename.split('.')[-1]
-        maxlength = max(len(ename), maxlength)
         exts[ename] = doc.splitlines()[0].strip()
 
-    return exts, maxlength
+    return exts