diff contrib/check-code.py @ 48870:df56e6bd37f6

py3: use pickle directly

pycompat.pickle abstracted over the different pickle modules in
Python 2 and 3. Now that we're Python 3 only, it is safe to use the
`pickle` module directly. So this commit does that.

As part of this we remove the rules from check-code.py that were
forbidden direct pickle module use.

We retain the `util.pickle` symbol for backwards compatibility, just
in case some extensions were using it.

Differential Revision: https://phab.mercurial-scm.org/D12249

--- a/contrib/check-code.py	Wed Mar 02 17:51:27 2022 -0800
+++ b/contrib/check-code.py	Tue Mar 01 20:29:03 2022 -0800
@@ -446,8 +446,6 @@
         ),
         (r'^import urlparse', "don't use urlparse, use util.urlreq"),
         (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"),
-        (r'^import cPickle', "don't use cPickle, use util.pickle"),
-        (r'^import pickle', "don't use pickle, use util.pickle"),
         (r'^import httplib', "don't use httplib, use util.httplib"),
         (r'^import BaseHTTPServer', "use util.httpserver instead"),
         (