diff contrib/check-code.py @ 16494:e1f0305eabe4 stable

tests: don't use /dev/urandom for largefiles testing There is no need to use entropy here just to create some content that only will be used for hashing and ignored. This avoids a problem where dd from /dev/urandom on solaris generates too short output.
author Mads Kiilerich <mads@kiilerich.com>
date Mon, 23 Apr 2012 01:56:48 +0200
parents 4fe874697a4d
children 5f9835ed3d6d
line wrap: on
line diff
--- a/contrib/check-code.py	Sun Apr 22 21:27:52 2012 -0400
+++ b/contrib/check-code.py	Mon Apr 23 01:56:48 2012 +0200
@@ -74,6 +74,7 @@
     (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
     (r'^alias\b.*=', "don't use alias, use a function"),
     (r'if\s*!', "don't use '!' to negate exit status"),
+    (r'/dev/u?random', "don't use entropy, use /dev/zero"),
   ],
   # warnings
   []