diff mercurial/changelog.py @ 23281:f60ed8cf4afc

transaction: pass the transaction to 'finalize' callback

The callback will likely need to perform some operation related to the
transaction (eg: registering file update). So we better pass the current
transaction as the callback argument. Otherwise callback that needs it has to
rely on horrible weak reference trick.

This allow already allow us to slay a wild weak reference usage.

--- a/mercurial/changelog.py	Sat Nov 08 16:27:50 2014 +0000
+++ b/mercurial/changelog.py	Sat Nov 08 16:31:38 2014 +0000
@@ -5,7 +5,6 @@
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
-import weakref
 from node import bin, hex, nullid
 from i18n import _
 import util, error, revlog, encoding
@@ -240,8 +239,7 @@
                                            self._delaybuf)
         self._delayed = True
         tr.addpending('cl-%i' % id(self), self._writepending)
-        trp = weakref.proxy(tr)
-        tr.addfinalize('cl-%i' % id(self), lambda: self._finalize(trp))
+        tr.addfinalize('cl-%i' % id(self), self._finalize)
 
     def _finalize(self, tr):
         "finalize index updates"