Mercurial > hg

diff contrib/check-code.py @ 17957:fbe43efe4a53

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: move i18n check from warning to error
author Matt Mackall <mpm@selenic.com>
date Sun, 25 Nov 2012 13:57:00 -0600
parents cf204e9829f4
children b35e3364f94a
line wrap: on
line diff
--- a/contrib/check-code.py	Sun Nov 25 13:53:47 2012 -0600
+++ b/contrib/check-code.py	Sun Nov 25 13:57:00 2012 -0600
@@ -211,11 +211,11 @@
     (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"),
     (r'^\s*except\s*:', "warning: naked except clause", r'#.*re-raises'),
     (r':\n(    )*( ){1,3}[^ ]', "must indent 4 spaces"),
+    (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
+     "missing _() in ui message (use () to hide false-positives)"),
   ],
   # warnings
   [
-    (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
-     "warning: unwrapped ui message"),
   ]
 ]