Mercurial > hg
view tests/blacklists/README @ 41163:0101a35deae2
phabricator: warn if unable to amend, instead of aborting after posting
There was a divergence in behavior here between obsolete and strip based
amending. I first noticed the abort when testing outside of the test harness,
but then had trouble recreating it here after reverting the code changes. It
turns out, strip based amend was successfully amending the public commit after
it was posted! It looks like the protection is in the `commit --amend` command,
not in the underlying code that it calls.
I considered doing a preflight check and aborting. But the locks are only
acquired at the end, if amending, and this is too large a section of code to be
wrapped in a maybe-it's-held-or-not context manager for my tastes.
Additionally, some people do post-push reviews, and amending is the default
behavior, so they shouldn't see a misleading error message.
The lack of a 'Differential Revision' entry in the commit message breaks a
{phabreview} test, so it had to be partially conditionalized.
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 05 Jan 2019 15:20:33 -0500 |
parents | c437745f50ec |
children |
line wrap: on
line source
Put here definitions of blacklists for run-tests.py Create a file per blacklist. Each file should list the names of tests that you want to be skipped. File names are meant to be used as targets for run-tests.py --blacklist option. Lines starting with # are ignored. White spaces are stripped. e.g. if you create a blacklist/example file containing: test-hgrc # some comment test-help then calling "run-tests.py --blacklist blacklists/example" will exclude test-hgrc and test-help from the list of tests to run.