Mercurial > hg
view tests/test-remotefilelog-wireproto.t @ 41163:0101a35deae2
phabricator: warn if unable to amend, instead of aborting after posting
There was a divergence in behavior here between obsolete and strip based
amending. I first noticed the abort when testing outside of the test harness,
but then had trouble recreating it here after reverting the code changes. It
turns out, strip based amend was successfully amending the public commit after
it was posted! It looks like the protection is in the `commit --amend` command,
not in the underlying code that it calls.
I considered doing a preflight check and aborting. But the locks are only
acquired at the end, if amending, and this is too large a section of code to be
wrapped in a maybe-it's-held-or-not context manager for my tastes.
Additionally, some people do post-push reviews, and amending is the default
behavior, so they shouldn't see a misleading error message.
The lack of a 'Differential Revision' entry in the commit message breaks a
{phabreview} test, so it had to be partially conditionalized.
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Sat, 05 Jan 2019 15:20:33 -0500 |
parents | 0800d9e6e216 |
children | dcaa2df1f688 |
line wrap: on
line source
#require no-windows $ . "$TESTDIR/remotefilelog-library.sh" $ hg init master $ cd master $ cat >> .hg/hgrc <<EOF > [remotefilelog] > server=True > EOF $ echo x > x $ hg commit -qAm x $ echo y >> x $ hg commit -qAm y $ echo z >> x $ hg commit -qAm z $ hg update 1 1 files updated, 0 files merged, 0 files removed, 0 files unresolved $ echo w >> x $ hg commit -qAm w $ cd .. Shallow clone and activate getflogheads testing extension $ hgcloneshallow ssh://user@dummy/master shallow --noupdate streaming all changes 2 files to transfer, 908 bytes of data transferred 908 bytes in * seconds (*/sec) (glob) searching for changes no changes found $ cd shallow $ cat >> .hg/hgrc <<EOF > [extensions] > getflogheads=$TESTDIR/remotefilelog-getflogheads.py > EOF Get heads of a remotefilelog $ hg getflogheads x 2797809ca5e9c2f307d82b1345e832f655fb99a2 ca758b402ddc91e37e3113e1a97791b537e1b7bb Get heads of a non-existing remotefilelog $ hg getflogheads y EMPTY