view tests/test-check-pyflakes.t @ 44261:04a3ae7aba14

chg: force-set LC_CTYPE on server start to actual value from the environment

Python 3.7+ will "coerce" the LC_CTYPE variable in many instances, and this can
cause issues with chg being able to start up. D7550 attempted to fix this, but a
combination of a misreading of the way that python3.7 does the coercion and an
untested state (LC_CTYPE being set to an invalid value) meant that this was
still not quite working.

This change will cause differences between chg and hg: hg will have the LC_CTYPE
environment variable coerced, while chg will not. This is unlikely to cause any
detectable behavior differences in what Mercurial itself outputs, but it does
have two known effects:

-   When using hg, the coerced LC_CTYPE will be passed to subprocesses, even
    non-python ones. Using chg will remove the coercion, and this will not
    happen. This is arguably more correct behavior on chg's part.
-   On macOS, if you set your region to Brazil but your language to English,
    this isn't representable in locale strings, so macOS sets LC_CTYPE=UTF-8. If
    this value is passed along when ssh'ing to a non-macOS machine, some
    functions (such as locale.setlocale()) may raise an exception due to an
    unsupported locale setting. This is most easily encountered when doing an
    interactive commit/split/etc. when using ui.interface=curses.

Differential Revision: https://phab.mercurial-scm.org/D8039

#require test-repo pyflakes hg10

  $ . "$TESTDIR/helpers-testrepo.sh"

run pyflakes on all tracked files ending in .py or without a file ending
(skipping binary file random-seed)

  $ cat > test.py <<EOF
  > print(undefinedname)
  > EOF
  $ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
  test.py:1: undefined name 'undefinedname'
  
  $ cd "`dirname "$TESTDIR"`"

  $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
  > -X hgext/fsmonitor/pywatchman \
  > -X mercurial/pycompat.py -X contrib/python-zstandard \
  > -X mercurial/thirdparty/cbor \
  > -X mercurial/thirdparty/concurrent \
  > -X mercurial/thirdparty/zope \
  > 2>/dev/null \
  > | xargs pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
  contrib/perf.py:*: undefined name 'xrange' (glob) (?)
  mercurial/hgweb/server.py:*: undefined name 'reload' (glob) (?)
  mercurial/util.py:*: undefined name 'file' (glob) (?)
  mercurial/encoding.py:*: undefined name 'localstr' (glob) (?)