view tests/test-rebase-detach.out @ 12039:18e1e7520b67 stable

alias: make shadowing behavior more consistent (issue2054)

Currently, given an alias like the following:

    [alias]
    summary = summary --remote

The alias might be executed - or it might not - depending on the order
of the cmdtable dict.

This happens because cmdalias gets assigned back to the cmdtable like so:

    cmdtable['summary'] = ...

Yet '^summary|sum' is still in the table, so which one cmdutil.findcmd()
chooses isn't deterministic.

This patch makes cmdalias assign back to '^summary|sum'. It uses the same
cmdtable key lookup that extensions.wrapcommand() does.

@  4: E
|
| o  3: D
| |
| o  2: C
| |
| o  1: B
|/
o  0: A

% Rebasing D onto E detaching from C
saved backup bundle to 
@  4: D
|
o  3: E
|
| o  2: C
| |
| o  1: B
|/
o  0: A

Expected A, D, E
A
D
E

@  4: E
|
| o  3: D
| |
| o  2: C
| |
| o  1: B
|/
o  0: A

% Rebasing C onto E detaching from B
saved backup bundle to 
@  4: D
|
o  3: C
|
o  2: E
|
| o  1: B
|/
o  0: A

Expected A, C, D, E
A
C
D
E

@  4: E
|
| o  3: D
| |
| o  2: C
| |
| o  1: B
|/
o  0: A

% Rebasing B onto E using detach (same as not using it)
saved backup bundle to 
@  4: D
|
o  3: C
|
o  2: B
|
o  1: E
|
o  0: A

Expected A, B, C, D, E
A
B
C
D
E

@  4: E
|
| o  3: D
| |
| o  2: C
| |
| o  1: B
|/
o  0: A

% Rebasing C onto E detaching from B and collapsing
saved backup bundle to 
@  3: Collapsed revision
|  * C
|  * D
o  2: E
|
| o  1: B
|/
o  0: A

Expected A, C, D, E
A
C
D
E