view tests/test-share.out @ 12039:18e1e7520b67 stable

alias: make shadowing behavior more consistent (issue2054)

Currently, given an alias like the following:

    [alias]
    summary = summary --remote

The alias might be executed - or it might not - depending on the order
of the cmdtable dict.

This happens because cmdalias gets assigned back to the cmdtable like so:

    cmdtable['summary'] = ...

Yet '^summary|sum' is still in the table, so which one cmdutil.findcmd()
chooses isn't deterministic.

This patch makes cmdalias assign back to '^summary|sum'. It uses the same
cmdtable key lookup that extensions.wrapcommand() does.

% prepare repo1
adding a
% share it
updating working directory
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
% contents of repo2/.hg
pass: .hg/store does not exist
$HGTMP/test-share/repo1/.hg
% commit in shared clone
% check original
changeset:   1:8af4dc49db9e
tag:         tip
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     change in shared clone

changeset:   0:d3873e73d99e
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     init

1 files updated, 0 files merged, 0 files removed, 0 files unresolved
a
a
% commit in original
adding b
% check in shared clone
changeset:   2:c2e0ac586386
tag:         tip
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     another file

changeset:   1:8af4dc49db9e
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     change in shared clone

changeset:   0:d3873e73d99e
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     init

1 files updated, 0 files merged, 0 files removed, 0 files unresolved
b
% hg serve shared clone
200 Script output follows


-rw-r--r-- 4 a
-rw-r--r-- 2 b