extensions: load and configure extensions in well-defined phases
Extensions are now loaded with a call-graph like this:
dispatch._dispatch
extensions.loadall
extensions.load
# add foo module to extensions._extensions
extensions.load
# add bar module to extensions._extensions
foo.uisetup(ui)
bar.uisetup(ui)
foo.extsetup()
bar.extsetup()
commands.table.update(foo.cmdtable)
commands.table.update(bar.cmdtable)
hg.repository
foo.reposetup(ui, repo)
bar.reposetup(ui, repo)
The uisetup calls could easily be moved out to dispatch._dispatch, but
have been kept in extensions.loadall since at least TortoiseHg calls
extensions.loadall and expects it to call uisetup.
The extensions.load function called uisetup. It now has an unused ui
argument which has been kept for backwards compatibility.
#!/bin/sh
# test that new files created in .hg inherit the permissions from .hg/store
"$TESTDIR/hghave" unix-permissions || exit 80
mkdir dir
# just in case somebody has a strange $TMPDIR
chmod g-s dir
cd dir
cat >printmodes.py <<EOF
import os, sys
allnames = []
isdir = {}
for root, dirs, files in os.walk(sys.argv[1]):
for d in dirs:
name = os.path.join(root, d)
isdir[name] = 1
allnames.append(name)
for f in files:
name = os.path.join(root, f)
allnames.append(name)
allnames.sort()
for name in allnames:
suffix = name in isdir and '/' or ''
print '%05o %s%s' % (os.lstat(name).st_mode & 07777, name, suffix)
EOF
cat >mode.py <<EOF
import sys
import os
print '%05o' % os.lstat(sys.argv[1]).st_mode
EOF
umask 077
hg init repo
cd repo
chmod 0770 .hg/store
echo '% before commit'
echo '% store can be written by the group, other files cannot'
echo '% store is setgid'
python ../printmodes.py .
mkdir dir
touch foo dir/bar
hg ci -qAm 'add files'
echo
echo '% after commit'
echo '% working dir files can only be written by the owner'
echo '% files created in .hg can be written by the group'
echo '% (in particular, store/**, dirstate, branch cache file, undo files)'
echo '% new directories are setgid'
python ../printmodes.py .
umask 007
hg init ../push
echo
echo '% before push'
echo '% group can write everything'
python ../printmodes.py ../push
umask 077
hg -q push ../push
echo
echo '% after push'
echo '% group can still write everything'
python ../printmodes.py ../push
# Test that we don't lose the setgid bit when we call chmod.
# Not all systems support setgid directories (e.g. HFS+), so
# just check that directories have the same mode.
cd ..
hg init setgid
cd setgid
chmod g+rwx .hg/store
chmod g+s .hg/store 2> /dev/null
mkdir dir
touch dir/file
hg ci -qAm 'add dir/file'
storemode=`python ../mode.py .hg/store`
dirmode=`python ../mode.py .hg/store/data/dir`
if [ "$storemode" != "$dirmode" ]; then
echo "$storemode != $dirmode"
fi