Mercurial > hg
view tests/test-simplekeyvaluefile.py @ 31751:2133437dad17
revlog: fix _cache usage in revision()
As documented at revlog.__init__, revlog._cache stores raw text.
The current read and write usage of "_cache" in revlog.revision lacks of
raw=True check.
This patch fixes that by adding check about raw, and storing rawtext
explicitly in _cache.
Note: it may slow down cache hit code path when raw=False and flags=0. That
performance issue will be fixed in a later patch.
test-revlog-raw now points us to a new problem.
author | Jun Wu <quark@fb.com> |
---|---|
date | Thu, 30 Mar 2017 15:34:08 -0700 |
parents | c6921568cd20 |
children | ed2c44741190 |
line wrap: on
line source
from __future__ import absolute_import import unittest import silenttestrunner from mercurial import ( error, scmutil, ) class mockfile(object): def __init__(self, name, fs): self.name = name self.fs = fs def __enter__(self): return self def __exit__(self, *args, **kwargs): pass def write(self, text): self.fs.contents[self.name] = text def read(self): return self.fs.contents[self.name] class mockvfs(object): def __init__(self): self.contents = {} def read(self, path): return mockfile(path, self).read() def readlines(self, path): return mockfile(path, self).read().split('\n') def __call__(self, path, mode, atomictemp): return mockfile(path, self) class testsimplekeyvaluefile(unittest.TestCase): def setUp(self): self.vfs = mockvfs() def testbasicwriting(self): d = {'key1': 'value1', 'Key2': 'value2'} scmutil.simplekeyvaluefile(self.vfs, 'kvfile').write(d) self.assertEqual(sorted(self.vfs.read('kvfile').split('\n')), ['', 'Key2=value2', 'key1=value1']) def testinvalidkeys(self): d = {'0key1': 'value1', 'Key2': 'value2'} self.assertRaises(error.ProgrammingError, scmutil.simplekeyvaluefile(self.vfs, 'kvfile').write, d) d = {'key1@': 'value1', 'Key2': 'value2'} self.assertRaises(error.ProgrammingError, scmutil.simplekeyvaluefile(self.vfs, 'kvfile').write, d) def testinvalidvalues(self): d = {'key1': 'value1', 'Key2': 'value2\n'} self.assertRaises(error.ProgrammingError, scmutil.simplekeyvaluefile(self.vfs, 'kvfile').write, d) def testcorruptedfile(self): self.vfs.contents['badfile'] = 'ababagalamaga\n' self.assertRaises(error.CorruptedState, scmutil.simplekeyvaluefile(self.vfs, 'badfile').read) if __name__ == "__main__": silenttestrunner.main(__name__)