Mercurial > hg
view .gitlab/merge_request_templates/Default.md @ 49273:34020d1f1635
parsers: drop one extra argument to PyErr_Format
GCC gave the following warning during `make local`:
mercurial/cext/parsers.c: In function 'dirstate_item_from_v1_data':
mercurial/cext/parsers.c:413:30: warning: too many arguments for format [-Wformat-extra-args]
413 | "unknown state: `%c` (%d, %d, %d)", state, mode,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
To reproduce, you might need to add the -Wformat-extra-args flag, because it
isn't present for me when building for the default python3. But I can see this
warning while simply building 6.1 with `make PYTHON=python2 clean local`.
I don't think this NULL was useful, because other instances of PyErr_Format()
don't have any NULLs as the final argument, but keep in mind that I don't know
python's C API.
author | Anton Shestakov <av6@dwimlabs.net> |
---|---|
date | Mon, 06 Jun 2022 13:58:32 +0400 |
parents | 7b0cf4517d82 |
children | 7b6d3a9bd7be |
line wrap: on
line source
/assign_reviewer @mercurial.review Welcome to the Mercurial Merge Request creation process: * Set a simple title for your MR, * All important information should be contained in your changesets' content or description, * You can add some workflow-relevant information here (eg: when this depends on another MR), * If your changes are not ready for review yet, click `Start the title with Draft:` under the title. More details here: * https://www.mercurial-scm.org/wiki/ContributingChanges * https://www.mercurial-scm.org/wiki/Heptapod