view .jshintrc @ 38178:3790efb388ca stable

lfs: bypass wrapped functions when reposetup() hasn't been called (issue5902)

There are only a handful of methods that access repo attributes that are applied
in reposetup().  The `diff` test covers all of the commands that call
scmutil.prefetchfiles().  Along the way, I saw that adding files and upgrading
the repo format were also problems (also tested here).

I don't think running `hg serve` through the commandserver is sane, but I
conditionalized both the capabilities and the wsgirequest handler because it's
trivially correct.  It doesn't look like there has ever been a caller of
candownload(), so there's no test for that path.

The upload case isn't testable, because uploadblobs() bails if there are no
pointers.  The requirement should be added any time pointers are introduced, and
that would force the extension to be loaded specifically for the repo.  This
covers `debuglfsupload`, the pre-push hook (which isn't set until the repo is
promoted to LFS), and uploadblobsfromrevs(), which can be called by other
extensions.

I think readfromstore() and writetostore() are only reachable as a flag
processor for revlog.REVIDX_EXTSTORED, and a requirement is added as soon as
that is seen, so I don't think those are a problem.

{
    // Enforcing
    "eqeqeq"        : true,     // true: Require triple equals (===) for comparison
    "forin"         : true,     // true: Require filtering for..in loops with obj.hasOwnProperty()
    "freeze"        : true,     // true: prohibits overwriting prototypes of native objects such as Array, Date etc.
    "nonbsp"        : true,     // true: Prohibit "non-breaking whitespace" characters.
    "undef"         : true,     // true: Require all non-global variables to be declared (prevents global leaks)

    // Environments
    "browser"       : true      // Web Browser (window, document, etc)
}