Mercurial > hg
view .gitlab/merge_request_templates/Default.md @ 51686:39033e7a6e0a
convert: stringify `shlex` class argument
The documentation is handwavy, but typeshed says this should be `str`[1]. I'm
not sure if this is the correct encoding (vs `fsencode` or "latin1" like the
tokens returned by the proxy class).
While we're here, we can add a few more type hints that would have caused pytype
to flag the problem.
[1] https://github.com/python/typeshed/blob/6a9b53e719a139c2d6b41cf265ed0990cf438192/stdlib/shlex.pyi#L51
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Thu, 11 Jul 2024 21:16:45 -0400 |
parents | 7b6d3a9bd7be |
children |
line wrap: on
line source
/assign_reviewer @mercurial.review <!-- Welcome to the Mercurial Merge Request creation process: * Set a simple title for your MR, * All important information should be contained in your changesets' content or description, * You can add some workflow-relevant information here (eg: when this depends on another MR), * If your changes are not ready for review yet, click `Start the title with Draft:` under the title. More details here: * https://www.mercurial-scm.org/wiki/ContributingChanges * https://www.mercurial-scm.org/wiki/Heptapod -->