Mercurial > hg
view tests/test-remotefilelog-bad-configs.t @ 41704:3b0ba4575c8c
exchange: raise error.Abort instead of ValueError
Raising ValueError results in an uncaught exception and a traceback
being printed. In the context of servers, it can result in an HTTP
500 and an exception being logged in the error log.
I don't think this is proper behavior.
The bundle2 code paths have a mechanism for translating an
error.Abort into an error message reported to the clients. I
think we should use that instead.
This commit replaces some ValueError with Abort so that
servers can error more gracefully.
Differential Revision: https://phab.mercurial-scm.org/D5972
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Fri, 15 Feb 2019 11:31:17 -0800 |
parents | 0800d9e6e216 |
children |
line wrap: on
line source
#require no-windows $ . "$TESTDIR/remotefilelog-library.sh" $ hg init master $ cd master $ cat >> .hg/hgrc <<EOF > [remotefilelog] > server=True > EOF $ echo x > x $ echo y > y $ echo z > z $ hg commit -qAm xy $ cd .. $ hgcloneshallow ssh://user@dummy/master shallow -q 3 files fetched over 1 fetches - (3 misses, 0.00% hit ratio) over *s (glob) $ cd shallow Verify error message when noc achepath specified $ hg up -q null $ cp $HGRCPATH $HGRCPATH.bak $ grep -v cachepath < $HGRCPATH.bak > tmp $ mv tmp $HGRCPATH $ hg up tip abort: could not find config option remotefilelog.cachepath [255] $ mv $HGRCPATH.bak $HGRCPATH Verify error message when no fallback specified $ hg up -q null $ rm .hg/hgrc $ clearcache $ hg up tip 3 files fetched over 1 fetches - (3 misses, 0.00% hit ratio) over *s (glob) abort: no remotefilelog server configured - is your .hg/hgrc trusted? [255]