Mercurial > hg
view tests/test-releasenotes-parsing.t @ 40923:3ed77780f4a6
wireprotov2: send linknodes to emitfilerevisions()
Previously, linknodes were calculated within emitfilerevisions() by
using filectx.introrev(), which would always use the linkrev/linknode
as recorded by storage. This is wrong for cases where the receiver
doesn't have the changeset the linknode refers to.
This commit changes the logic for linknode emission so the mapping
of filenode to linknode is computed by the caller and passed into
emitfilerevisions().
As part of the change, linknodes for "filesdata" in the
haveparents=False case are now correct: the existing code performed a
manifest walk and it was trivial to plug in the correct linknode.
However, behavior for the haveparents=True case is still wrong
because it relies on filtering linkrevs against the outgoing set in
order to determine what to send. This will be fixed in a subsequent
commit.
The change test test-wireproto-exchangev2-shallow.t is a bit wonky.
The test repo has 6 revisions. The changed test is performing a shallow
clone with depth=1. So, only file data for revision 5 is present
locally. So, the new behavior of associating the linknode with
revision 5 for every file revision seems correct. Of course, when
backfilling old revisions, we'll want to update the linknode. But
this problem requires wire protocol support and we'll cross that
bridge later.
Differential Revision: https://phab.mercurial-scm.org/D5405
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Mon, 10 Dec 2018 18:04:12 +0000 |
parents | 3fff6f30bd7f |
children |
line wrap: on
line source
#require fuzzywuzzy $ cat >> $HGRCPATH << EOF > [extensions] > releasenotes= > EOF Bullet point with a single item spanning a single line $ hg debugparsereleasenotes - << EOF > New Features > ============ > > * Bullet point item with a single line > EOF section: feature bullet point: paragraph: Bullet point item with a single line Bullet point that spans multiple lines. $ hg debugparsereleasenotes - << EOF > New Features > ============ > > * Bullet point with a paragraph > that spans multiple lines. > EOF section: feature bullet point: paragraph: Bullet point with a paragraph that spans multiple lines. $ hg debugparsereleasenotes - << EOF > New Features > ============ > > * Bullet point with a paragraph > that spans multiple lines. > > And has an empty line between lines too. > With a line cuddling that. > EOF section: feature bullet point: paragraph: Bullet point with a paragraph that spans multiple lines. paragraph: And has an empty line between lines too. With a line cuddling that. Multiple bullet points. With some entries being multiple lines. $ hg debugparsereleasenotes - << EOF > New Features > ============ > > * First bullet point. It has a single line. > > * Second bullet point. > It consists of multiple lines. > > * Third bullet point. It has a single line. > EOF section: feature bullet point: paragraph: First bullet point. It has a single line. bullet point: paragraph: Second bullet point. It consists of multiple lines. bullet point: paragraph: Third bullet point. It has a single line. Bullet point without newline between items $ hg debugparsereleasenotes - << EOF > New Features > ============ > > * First bullet point > * Second bullet point > And it has multiple lines > * Third bullet point > * Fourth bullet point > EOF section: feature bullet point: paragraph: First bullet point bullet point: paragraph: Second bullet point And it has multiple lines bullet point: paragraph: Third bullet point bullet point: paragraph: Fourth bullet point Sub-section contents are read $ hg debugparsereleasenotes - << EOF > New Features > ============ > > First Feature > ------------- > > This is the first new feature that was implemented. > > And a second paragraph about it. > > Second Feature > -------------- > > This is the second new feature that was implemented. > > Paragraph two. > > Paragraph three. > EOF section: feature subsection: First Feature paragraph: This is the first new feature that was implemented. paragraph: And a second paragraph about it. subsection: Second Feature paragraph: This is the second new feature that was implemented. paragraph: Paragraph two. paragraph: Paragraph three. Multiple sections are read $ hg debugparsereleasenotes - << EOF > New Features > ============ > > * Feature 1 > * Feature 2 > > Bug Fixes > ========= > > * Fix 1 > * Fix 2 > EOF section: feature bullet point: paragraph: Feature 1 bullet point: paragraph: Feature 2 section: fix bullet point: paragraph: Fix 1 bullet point: paragraph: Fix 2 Mixed sub-sections and bullet list $ hg debugparsereleasenotes - << EOF > New Features > ============ > > Feature 1 > --------- > > Some words about the first feature. > > Feature 2 > --------- > > Some words about the second feature. > That span multiple lines. > > Other Changes > ------------- > > * Bullet item 1 > * Bullet item 2 > EOF section: feature subsection: Feature 1 paragraph: Some words about the first feature. subsection: Feature 2 paragraph: Some words about the second feature. That span multiple lines. bullet point: paragraph: Bullet item 1 bullet point: paragraph: Bullet item 2 Warn user in case of unexpected block while parsing $ hg init relnotes-warn $ cd relnotes-warn $ touch feature1 $ hg -q commit -A -l - << EOF > commit 1 > > .. feature:: > > new feature added. > some words about the feature. > EOF $ hg releasenote -r . changeset a4251905c440: unexpected block in release notes directive feature New Features ============ * new feature added. some words about the feature. $ cd ..