view tests/test-bookmarks-rebase.out @ 12252:4481f8a93c7a stable

convert/darcs: handle non-ASCII metadata in darcs changelog (issue2354)

Given a commit author or message with non-ASCII characters in a darcs
repo, convert would raise a UnicodeEncodeError when adding changesets
to the hg changelog.

This happened because etree returns back unicode objects for any text
it can't encode into ASCII. convert was passing these objects to
changelog.add(), which would then attempt encoding.fromlocal() on
them.

This patch ensures converter_source.recode() is called on each piece
of commit data returned by etree.

(Also note that darcs is currently encoding agnostic and will print
out whatever is in a patch's metadata byte-for-byte, even in the XML
changelog.)

% initialize repository
adding a
adding b
0 files updated, 0 files merged, 1 files removed, 0 files unresolved
adding c
created new head
adding d
% bookmark list
 * two                       3:2ae46b1d99a7
   one                       1:925d80f479bb
% rebase
saved backup bundle to 
changeset:   3:9163974d1cb5
tag:         one
tag:         tip
tag:         two
parent:      1:925d80f479bb
parent:      2:db815d6d32e6
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     3

changeset:   2:db815d6d32e6
parent:      0:f7b1eb17ad24
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     2

changeset:   1:925d80f479bb
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     1

changeset:   0:f7b1eb17ad24
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     0