view tests/test-children.out @ 12252:4481f8a93c7a stable

convert/darcs: handle non-ASCII metadata in darcs changelog (issue2354)

Given a commit author or message with non-ASCII characters in a darcs
repo, convert would raise a UnicodeEncodeError when adding changesets
to the hg changelog.

This happened because etree returns back unicode objects for any text
it can't encode into ASCII. convert was passing these objects to
changelog.add(), which would then attempt encoding.fromlocal() on
them.

This patch ensures converter_source.recode() is called on each piece
of commit data returned by etree.

(Also note that darcs is currently encoding agnostic and will print
out whatever is in a patch's metadata byte-for-byte, even in the XML
changelog.)

% init
% no working directory
% setup
0 files updated, 0 files merged, 2 files removed, 0 files unresolved
% hg children at revision 3 (tip)
0 files updated, 0 files merged, 1 files removed, 0 files unresolved
% hg children at nullrev (should be 0 and 3)
changeset:   0:4df8521a7374
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     0

changeset:   3:e2962852269d
tag:         tip
parent:      -1:000000000000
user:        test
date:        Thu Jan 01 00:00:03 1970 +0000
summary:     3

2 files updated, 0 files merged, 0 files removed, 0 files unresolved
% hg children at revision 1 (should be 2)
changeset:   2:8f5eea5023c2
user:        test
date:        Thu Jan 01 00:00:02 1970 +0000
summary:     2

1 files updated, 0 files merged, 0 files removed, 0 files unresolved
% hg children at revision 2 (other head)
% hg children -r null
changeset:   0:4df8521a7374
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     0

changeset:   3:e2962852269d
tag:         tip
parent:      -1:000000000000
user:        test
date:        Thu Jan 01 00:00:03 1970 +0000
summary:     3

% hg children -r 0
changeset:   1:708c093edef0
user:        test
date:        Thu Jan 01 00:00:01 1970 +0000
summary:     1

% hg children -r 1
changeset:   2:8f5eea5023c2
user:        test
date:        Thu Jan 01 00:00:02 1970 +0000
summary:     2

% hg children -r 2
% hg children -r 3
% hg children -r 0 file0 (should be 2)
changeset:   2:8f5eea5023c2
user:        test
date:        Thu Jan 01 00:00:02 1970 +0000
summary:     2

% hg children -r 1 file0 (should be 2)
changeset:   2:8f5eea5023c2
user:        test
date:        Thu Jan 01 00:00:02 1970 +0000
summary:     2

1 files updated, 0 files merged, 1 files removed, 0 files unresolved
% hg children file0 at revision 0 (should be 2)
changeset:   2:8f5eea5023c2
user:        test
date:        Thu Jan 01 00:00:02 1970 +0000
summary:     2