view tests/test-convert-bzr-directories.out @ 12252:4481f8a93c7a stable

convert/darcs: handle non-ASCII metadata in darcs changelog (issue2354)

Given a commit author or message with non-ASCII characters in a darcs
repo, convert would raise a UnicodeEncodeError when adding changesets
to the hg changelog.

This happened because etree returns back unicode objects for any text
it can't encode into ASCII. convert was passing these objects to
changelog.add(), which would then attempt encoding.fromlocal() on
them.

This patch ensures converter_source.recode() is called on each piece
of commit data returned by etree.

(Also note that darcs is currently encoding agnostic and will print
out whatever is in a patch's metadata byte-for-byte, even in the XML
changelog.)

% empty directory
initializing destination source-hg repository
scanning source...
sorting...
converting...
2 Initial add
1 Empty directory added
0 Added file into directory
% manifest of 1
644   a
% manifest of tip
644   a
644   empty/something
% directory renames
tpyo => typo
initializing destination source-hg repository
scanning source...
sorting...
converting...
1 Added directory
0 Oops, typo
% manifest of 0
644   tpyo/something
% manifest of tip
644   typo/something
% nested directory renames
firstlevel/secondlevel => secondlevel
initializing destination source-hg repository
scanning source...
sorting...
converting...
1 Added nested directories
0 Moved secondlevel one level up
% manifest of tip
644   secondlevel/file
644   secondlevel/thirdlevel/stuff
% directory remove
initializing destination source-hg repository
scanning source...
sorting...
converting...
1 Added directory
0 Removed directory
% manifest of 0
644   src/sourcecode
% manifest of tip
% directory replace
first/file => second/file
first => third
initializing destination source-hg repository
scanning source...
sorting...
converting...
1 Initial layout
0 Some conflicting moves
% manifest of tip
644   second/file
644   second/something
644   third/dummy