view tests/test-manifest.out @ 12252:4481f8a93c7a stable

convert/darcs: handle non-ASCII metadata in darcs changelog (issue2354)

Given a commit author or message with non-ASCII characters in a darcs
repo, convert would raise a UnicodeEncodeError when adding changesets
to the hg changelog.

This happened because etree returns back unicode objects for any text
it can't encode into ASCII. convert was passing these objects to
changelog.add(), which would then attempt encoding.fromlocal() on
them.

This patch ensures converter_source.recode() is called on each piece
of commit data returned by etree.

(Also note that darcs is currently encoding agnostic and will print
out whatever is in a patch's metadata byte-for-byte, even in the XML
changelog.)

% should be empty
3 files updated, 0 files merged, 0 files removed, 0 files unresolved
a
b/a
l
644   a
755 * b/a
644 @ l
b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3 644   a
b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3 755 * b/a
047b75c6d7a3ef6a2243bd0e99f94f6ea6683597 644 @ l
a
l
a
b/a
l
a
b/a
l
% should fail
abort: unknown revision '2'!
abort: please specify just one revision
a
b/a
l