view tests/test-mq-qrefresh-replace-log-message.out @ 12252:4481f8a93c7a stable

convert/darcs: handle non-ASCII metadata in darcs changelog (issue2354)

Given a commit author or message with non-ASCII characters in a darcs
repo, convert would raise a UnicodeEncodeError when adding changesets
to the hg changelog.

This happened because etree returns back unicode objects for any text
it can't encode into ASCII. convert was passing these objects to
changelog.add(), which would then attempt encoding.fromlocal() on
them.

This patch ensures converter_source.recode() is called on each piece
of commit data returned by etree.

(Also note that darcs is currently encoding agnostic and will print
out whatever is in a patch's metadata byte-for-byte, even in the XML
changelog.)

=======================
Should fail if no patches applied
no patches applied
no patches applied
=======================
Should display 'First commit message'
description:
First commit message



=======================
Should display 'Second commit message'
description:
Second commit message



=======================
Should display 'Third commit message\n This is the 3rd log message'
description:
Third commit message
 This is the 3rd log message



=======================
Should display 'Fifth commit message\n This is the 5th log message'
description:
Fifth commit message