view tests/test-notify-changegroup.out @ 12252:4481f8a93c7a stable

convert/darcs: handle non-ASCII metadata in darcs changelog (issue2354)

Given a commit author or message with non-ASCII characters in a darcs
repo, convert would raise a UnicodeEncodeError when adding changesets
to the hg changelog.

This happened because etree returns back unicode objects for any text
it can't encode into ASCII. convert was passing these objects to
changelog.add(), which would then attempt encoding.fromlocal() on
them.

This patch ensures converter_source.recode() is called on each piece
of commit data returned by etree.

(Also note that darcs is currently encoding agnostic and will print
out whatever is in a patch's metadata byte-for-byte, even in the XML
changelog.)

% clone
updating to branch default
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
% commit
adding a
% commit
% push
pushing to ../a
searching for changes
adding changesets
adding manifests
adding file changes
added 2 changesets with 2 changes to 1 files
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Date:
Subject: test-notify-changegroup
From: test
X-Hg-Notification: changeset cb9a9f314b8b
Message-Id:
To: baz, foo@bar

changeset cb9a9f314b8b in test-notify-changegroup/a
details: test-notify-changegroup/a?cmd=changeset;node=cb9a9f314b8b
summary: a

changeset ba677d0156c1 in test-notify-changegroup/a
details: test-notify-changegroup/a?cmd=changeset;node=ba677d0156c1
summary: b

diffs (6 lines):

diff -r 000000000000 -r ba677d0156c1 a
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/a	Thu Jan 01 00:00:00 1970 +0000
@@ -0,0 +1,2 @@
+a
+a