view tests/test-share.out @ 12252:4481f8a93c7a stable

convert/darcs: handle non-ASCII metadata in darcs changelog (issue2354)

Given a commit author or message with non-ASCII characters in a darcs
repo, convert would raise a UnicodeEncodeError when adding changesets
to the hg changelog.

This happened because etree returns back unicode objects for any text
it can't encode into ASCII. convert was passing these objects to
changelog.add(), which would then attempt encoding.fromlocal() on
them.

This patch ensures converter_source.recode() is called on each piece
of commit data returned by etree.

(Also note that darcs is currently encoding agnostic and will print
out whatever is in a patch's metadata byte-for-byte, even in the XML
changelog.)

% prepare repo1
adding a
% share it
updating working directory
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
% contents of repo2/.hg
pass: .hg/store does not exist
$HGTMP/test-share/repo1/.hg
% commit in shared clone
% check original
changeset:   1:8af4dc49db9e
tag:         tip
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     change in shared clone

changeset:   0:d3873e73d99e
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     init

1 files updated, 0 files merged, 0 files removed, 0 files unresolved
a
a
% commit in original
adding b
% check in shared clone
changeset:   2:c2e0ac586386
tag:         tip
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     another file

changeset:   1:8af4dc49db9e
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     change in shared clone

changeset:   0:d3873e73d99e
user:        test
date:        Thu Jan 01 00:00:00 1970 +0000
summary:     init

1 files updated, 0 files merged, 0 files removed, 0 files unresolved
b
% hg serve shared clone
200 Script output follows


-rw-r--r-- 4 a
-rw-r--r-- 2 b