Mercurial > hg
view hgext/narrow/TODO.rst @ 49181:477b5145e1a0 stable
ci: do not trigger phabricator for merge-request
The fast the phabricator steps has a `rules` entry makes it selected for the
special `merge_requests` pipelines. The other ones behave as default and are not
selected tot the mrege_request pipelines.
This result in a second pipeline to be created, with only the phabricator
pipeline in it. Which usually succeed fast (since there is nothing to do).
This is harmful as this create a false sense of "the series is passing" and
Gitlab will use this simplistic pipeline for validation.
By explicitly preventing the pipeline to be created in the merge-request case,
we prevent this situation to happens
Note that the job will be dropped (alonside phabricator) in the next two weeks
anyway.
author | Pierre-Yves David <pierre-yves.david@octobus.net> |
---|---|
date | Tue, 17 May 2022 00:09:51 +0100 |
parents | ce0bc2952e2a |
children |
line wrap: on
line source
Address commentary in manifest.excludedmanifestrevlog.add - specifically we should improve the collaboration with core so that add() never gets called on an excluded directory and we can improve the stand-in to raise a ProgrammingError. Reason more completely about rename-filtering logic in narrowfilelog. There could be some surprises lurking there. Formally document the narrowspec format. For bonus points, unify with the server-specified narrowspec format. narrowrepo.setnarrowpats() or narrowspec.save() need to make sure they're holding the wlock. The follinwg places do an unrestricted dirstate walk (including files outside the narrowspec). Some of them should perhaps not do that. * debugfileset * perfwalk * sparse (but restricted to sparse config) * largefiles