Mercurial > hg
view mercurial/revlogutils/concurrency_checker.py @ 47072:4c041c71ec01
revlog: introduce an explicit tracking of what the revlog is about
Since the dawn of time, people have been forced to rely to lossy introspection
of the index filename to determine what the purpose and role of the revlog they
encounter is. This is hacky, error prone, inflexible, abstraction-leaky,
<insert-your-own-complaints-here>.
In f63299ee7e4d Raphaël introduced a new attribute to track this information:
`revlog_kind`. However it is initialized in an odd place and various instances
end up not having it set. In addition is only tracking some of the information
we end up having to introspect in various pieces of code.
So we add a new attribute that holds more data and is more strictly enforced.
This work is done in collaboration with Raphaël.
The `revlog_kind` one will be removed/adapted in the next changeset. We expect
to be able to clean up various existing piece of code and to simplify coming
work around the newer revlog format.
Differential Revision: https://phab.mercurial-scm.org/D10352
author | Pierre-Yves David <pierre-yves.david@octobus.net> |
---|---|
date | Tue, 06 Apr 2021 05:20:24 +0200 |
parents | e9901d01d135 |
children | 1c5810ce737e |
line wrap: on
line source
from ..i18n import _ from .. import error def get_checker(ui, revlog_name=b'changelog'): """Get a function that checks file handle position is as expected. This is used to ensure that files haven't been modified outside of our knowledge (such as on a networked filesystem, if `hg debuglocks` was used, or writes to .hg that ignored locks happened). Due to revlogs supporting a concept of buffered, delayed, or diverted writes, we're allowing the files to be shorter than expected (the data may not have been written yet), but they can't be longer. Please note that this check is not perfect; it can't detect all cases (there may be false-negatives/false-OKs), but it should never claim there's an issue when there isn't (false-positives/false-failures). """ vpos = ui.config(b'debug', b'revlog.verifyposition.' + revlog_name) # Avoid any `fh.tell` cost if this isn't enabled. if not vpos or vpos not in [b'log', b'warn', b'fail']: return None def _checker(fh, fn, expected): if fh.tell() <= expected: return msg = _(b'%s: file cursor at position %d, expected %d') # Always log if we're going to warn or fail. ui.log(b'debug', msg + b'\n', fn, fh.tell(), expected) if vpos == b'warn': ui.warn((msg + b'\n') % (fn, fh.tell(), expected)) elif vpos == b'fail': raise error.RevlogError(msg % (fn, fh.tell(), expected)) return _checker