Mercurial > hg
view tests/blacklists/fsmonitor @ 34107:4f60720cf0df
blackbox: fix rotation with chg
The added test will show:
$ $PYTHON showsize.py .hg/blackbox*
.hg/blackbox.log: < 500
.hg/blackbox.log.1: < 500
.hg/blackbox.log.2: < 500
.hg/blackbox.log.3: < 500
.hg/blackbox.log.4: < 500
.hg/blackbox.log.5: >= 500
with previous code.
The issue is caused by blackbox caching file objects *by path*, and the
rotation size check could run on a wrong file object (i.e. it should check
"blackbox.log", but `filehandles["blackbox.log"]` contains a file object
that has been renamed to "blackbox.log.5").
This patch removes the "filehandlers" global cache added by 45313f5a3a8c to
solve the issue.
I think the original patch was trying to make different ui objects use a same
file object if their blackbox.log path is the same. In theory it could also
be problematic in the rotation case. Anyway, that should become unnecessary
after D650.
Differential Revision: https://phab.mercurial-scm.org/D648
author | Jun Wu <quark@fb.com> |
---|---|
date | Wed, 06 Sep 2017 19:27:30 -0700 |
parents | 7a15cae3ec81 |
children |
line wrap: on
line source
# Blacklist for a full testsuite run with fsmonitor enabled. # Used by fsmonitor-run-tests. # The following tests all fail because they either use extensions that conflict # with fsmonitor, use subrepositories, or don't anticipate the extra file in # the .hg directory that fsmonitor adds. #### mainly testing eol extension test-eol-add.t test-eol-clone.t test-eol-hook.t test-eol-patch.t test-eol-tag.t test-eol-update.t test-eol.t test-eolfilename.t #### mainly testing largefiles extension test-issue3084.t test-largefiles-cache.t test-largefiles-misc.t test-largefiles-small-disk.t test-largefiles-update.t test-largefiles-wireproto.t test-largefiles.t test-lfconvert.t #### mainly testing nested repositories test-nested-repo.t test-push-warn.t test-subrepo-deep-nested-change.t test-subrepo-recursion.t test-subrepo.t #### fixing these seems redundant, because these don't focus on #### operations in the working directory or .hg test-debugextensions.t test-extension.t test-help.t