Mercurial > hg
view tests/bundles/remote.sh @ 34107:4f60720cf0df
blackbox: fix rotation with chg
The added test will show:
$ $PYTHON showsize.py .hg/blackbox*
.hg/blackbox.log: < 500
.hg/blackbox.log.1: < 500
.hg/blackbox.log.2: < 500
.hg/blackbox.log.3: < 500
.hg/blackbox.log.4: < 500
.hg/blackbox.log.5: >= 500
with previous code.
The issue is caused by blackbox caching file objects *by path*, and the
rotation size check could run on a wrong file object (i.e. it should check
"blackbox.log", but `filehandles["blackbox.log"]` contains a file object
that has been renamed to "blackbox.log.5").
This patch removes the "filehandlers" global cache added by 45313f5a3a8c to
solve the issue.
I think the original patch was trying to make different ui objects use a same
file object if their blackbox.log path is the same. In theory it could also
be problematic in the rotation case. Anyway, that should become unnecessary
after D650.
Differential Revision: https://phab.mercurial-scm.org/D648
author | Jun Wu <quark@fb.com> |
---|---|
date | Wed, 06 Sep 2017 19:27:30 -0700 |
parents | 5d57b2101ab1 |
children |
line wrap: on
line source
#!/usr/bin/env bash hg init remote cd remote echo "0" >> afile hg add afile hg commit -m "0.0" echo "1" >> afile hg commit -m "0.1" echo "2" >> afile hg commit -m "0.2" echo "3" >> afile hg commit -m "0.3" hg update -C 0 echo "1" >> afile hg commit -m "1.1" echo "2" >> afile hg commit -m "1.2" echo "a line" > fred echo "3" >> afile hg add fred hg commit -m "1.3" hg mv afile adifferentfile hg commit -m "1.3m" hg update -C 3 hg mv afile anotherfile hg commit -m "0.3m" hg bundle -a ../remote.hg cd .. rm -Rf remote