view tests/test-diff-issue2761.t @ 40131:535fc8a22365 stable

lfs: avoid a potential variable reference before assignment error in cmdserver

A coworker hit this once yesterday when pulling in thg (a retry worked), and
then I hit it with strip after a pull.  I had a difficult time recreating a test
for this (at least one of the tricks was to not use '-R', which seems to cause
reposetup() to be called for each command), so I'm not sure how large of a
window there actually is for this.  Calling reposetup() *after* the requirement
is added will skip the hook entirely.

The other issue I had was adding a couple `ui.status()` lines around the check
that installs the hook.  On Windows, the cmdserver process ballooned to 1.6GB
and hung.  Changing that to `ui.warn()` avoided the hang.  It also hung on
macOS, but without the large memory usage.

Test issue2761

  $ hg init

  $ touch to-be-deleted
  $ hg add
  adding to-be-deleted
  $ hg ci -m first
  $ echo a > to-be-deleted
  $ hg ci -m second
  $ rm to-be-deleted
  $ hg diff -r 0

Same issue, different code path

  $ hg up -C
  1 files updated, 0 files merged, 0 files removed, 0 files unresolved
  $ touch does-not-exist-in-1
  $ hg add
  adding does-not-exist-in-1
  $ hg ci -m third
  $ rm does-not-exist-in-1
  $ hg diff -r 1