Mercurial > hg
view mercurial/bitmanipulation.h @ 49803:55d45d0de4e7
typing: add type hints to pycompat.bytestr
The problem with leaving pytype to its own devices here was that for functions
that returned a bytestr, pytype inferred `Union[bytes, int]`. It now accepts
that it can be treated as plain bytes.
I wasn't able to figure out the arg type for `__getitem__`- `SupportsIndex`
(which PyCharm indicated is how the superclass function is typed) got flagged:
File "/mnt/c/Users/Matt/hg/mercurial/pycompat.py", line 236, in __getitem__:
unsupported operand type(s) for item retrieval: bytestr and SupportsIndex [unsupported-operands]
Function __getitem__ on bytestr expects int
But some caller got flagged when I marked it as `int`.
There's some minor spillover problems elsewhere- pytype doesn't seem to
recognize that `bytes.startswith()` can optionally take a 3rd and 4th arg, so
those few places have the warning disabled. It also flags where the tar API is
being abused, but that would be a tricky refactor (and would require typing
extensions until py3.7 is dropped), so disable those too.
author | Matt Harbison <matt_harbison@yahoo.com> |
---|---|
date | Wed, 14 Dec 2022 01:51:33 -0500 |
parents | d86908050375 |
children |
line wrap: on
line source
#ifndef HG_BITMANIPULATION_H #define HG_BITMANIPULATION_H #include <string.h> #include "compat.h" /* Reads a 64 bit integer from big-endian bytes. Assumes that the data is long enough */ static inline uint64_t getbe64(const char *c) { const unsigned char *d = (const unsigned char *)c; return ((((uint64_t)d[0]) << 56) | (((uint64_t)d[1]) << 48) | (((uint64_t)d[2]) << 40) | (((uint64_t)d[3]) << 32) | (((uint64_t)d[4]) << 24) | (((uint64_t)d[5]) << 16) | (((uint64_t)d[6]) << 8) | (d[7])); } static inline uint32_t getbe32(const char *c) { const unsigned char *d = (const unsigned char *)c; return ((((uint32_t)d[0]) << 24) | (((uint32_t)d[1]) << 16) | (((uint32_t)d[2]) << 8) | (d[3])); } static inline int16_t getbeint16(const char *c) { const unsigned char *d = (const unsigned char *)c; return ((d[0] << 8) | (d[1])); } static inline uint16_t getbeuint16(const char *c) { const unsigned char *d = (const unsigned char *)c; return ((d[0] << 8) | (d[1])); } /* Writes a 64 bit integer to bytes in a big-endian format. Assumes that the buffer is long enough */ static inline void putbe64(uint64_t x, char *c) { c[0] = (x >> 56) & 0xff; c[1] = (x >> 48) & 0xff; c[2] = (x >> 40) & 0xff; c[3] = (x >> 32) & 0xff; c[4] = (x >> 24) & 0xff; c[5] = (x >> 16) & 0xff; c[6] = (x >> 8) & 0xff; c[7] = (x)&0xff; } static inline void putbe32(uint32_t x, char *c) { c[0] = (x >> 24) & 0xff; c[1] = (x >> 16) & 0xff; c[2] = (x >> 8) & 0xff; c[3] = (x)&0xff; } static inline double getbefloat64(const char *c) { const unsigned char *d = (const unsigned char *)c; double ret; int i; uint64_t t = 0; for (i = 0; i < 8; i++) { t = (t << 8) + d[i]; } memcpy(&ret, &t, sizeof(t)); return ret; } #endif