view CONTRIBUTING @ 47941:5b9de38a0356 stable

narrow: fix commits of empty files

The problem is that when committing a new file with empty contents (or
in general empty file with filelog p1 = -1), hg commit with narrow
doesn't create a filelog revision at all, which causes failures in
further commands.

The problem seems to be that:
- hg thinks that instead of creating a new filelog revision, it can
  use the filelog's p1 (the nullrev)
- because it thinks the file contents is the same in that revision and
  in p1
- because `narrowfilelog.cmp(nullrev, b'')` is True (unlike with
  `filelog.cmp`)

It's not clear to me which `cmp` behaves better. But I think it makes
sense to change the commit code to not to "reuse" the null rev when
adding an empty file with filelog p1 == filelog p2 == -1. This is
consistent with never writing the null rev in the manifest, which `hg
verify` claims is an invariant:

```
inside/c@4: manifest refers to unknown revision 000000000000
```

Differential Revision: https://phab.mercurial-scm.org/D11400

Our full contribution guidelines are in our wiki, please see:

https://www.mercurial-scm.org/wiki/ContributingChanges

If you just want a checklist to follow, you can go straight to

https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

If you can't run the entire testsuite for some reason (it can be
difficult on Windows), please at least run `contrib/check-code.py` on
any files you've modified and run `python contrib/check-commit` on any
commits you've made (for example, `python contrib/check-commit
273ce12ad8f1` will report some style violations on a very old commit).