view CONTRIBUTING @ 44646:5f9c917e3b50

phabricator: teach `getoldnodedrevmap()` to handle folded reviews

The tricky part here is reasoning through all of the possible predecessor
scenarios.  In the typical case of submitting a folded range and then
resubmitting it (also folded), filtering the list of commits for the diff stored
on Phabricator through the local predecessor list for each single node will
result in the typical 1:1 mapping to the old node.

There are edge cases like using `hg fold` within the range prior to
resubmitting, that will result in mapping to multiple old nodes.  In that case,
the first direct predecessor is needed for the base of the diff, and the last
direct predecessor is needed for the head of the diff in order to make sure that
the entire range is included in the diff content.  And none of this matters for
commits in the middle of the range, as they are never used.

Fortunately the only crucial thing here is the `drev` number for each node.  For
these complicated cases where there are multiple old nodes, simply ignore them
all.  This will cause `createdifferentialrevision()` to generate a new diff
(within the same Differential), and avoids complicating the code.

Differential Revision: https://phab.mercurial-scm.org/D8311

Our full contribution guidelines are in our wiki, please see:

https://www.mercurial-scm.org/wiki/ContributingChanges

If you just want a checklist to follow, you can go straight to

https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist

If you can't run the entire testsuite for some reason (it can be
difficult on Windows), please at least run `contrib/check-code.py` on
any files you've modified and run `python contrib/check-commit` on any
commits you've made (for example, `python contrib/check-commit
273ce12ad8f1` will report some style violations on a very old commit).