Mercurial > hg
view tests/pullext.py @ 42943:5fadf6103790
remotefilelog: replace repack lock to solve race condition
2c74337e6483 reduced the probability of race-conditions when starting
background repack and prefetch and we saw the difference in our CI instance
with all failures disappearing except one where one call to waitonrepack seems
to returns too early.
I'm not sure what exactly goes wrong but I realized that while the prefetch
operation uses a standard Mercurial lock, the repack operation is using a
custom lock based on `fcntl.flock` on available platforms. As `extutil.flock`
fallback on traditional Mercurial locks on other platforms and the tests are
stable on my laptop, our CI environment and GCC112, I'm sending this patch to
standardize the behavior across environments.
Differential Revision: https://phab.mercurial-scm.org/D6844
author | Boris Feld <boris.feld@octobus.net> |
---|---|
date | Wed, 11 Sep 2019 17:41:13 +0200 |
parents | 268662aac075 |
children | 2372284d9457 |
line wrap: on
line source
# pullext.py - Simple extension to test pulling # # Copyright 2018 Gregory Szorc <gregory.szorc@gmail.com> # # This software may be used and distributed according to the terms of the # GNU General Public License version 2 or any later version. from __future__ import absolute_import from mercurial.i18n import _ from mercurial import ( commands, error, extensions, localrepo, ) from mercurial.interfaces import ( repository, ) def clonecommand(orig, ui, repo, *args, **kwargs): if kwargs.get(r'include') or kwargs.get(r'exclude'): kwargs[r'narrow'] = True if kwargs.get(r'depth'): try: kwargs[r'depth'] = int(kwargs[r'depth']) except ValueError: raise error.Abort(_('--depth must be an integer')) return orig(ui, repo, *args, **kwargs) def featuresetup(ui, features): features.add(repository.NARROW_REQUIREMENT) def extsetup(ui): entry = extensions.wrapcommand(commands.table, b'clone', clonecommand) hasinclude = any(x[1] == b'include' for x in entry[1]) hasdepth = any(x[1] == b'depth' for x in entry[1]) if not hasinclude: entry[1].append((b'', b'include', [], _(b'pattern of file/directory to clone'))) entry[1].append((b'', b'exclude', [], _(b'pattern of file/directory to not clone'))) if not hasdepth: entry[1].append((b'', b'depth', b'', _(b'ancestry depth of changesets to fetch'))) localrepo.featuresetupfuncs.add(featuresetup)