Mercurial > hg
view tests/test-py3-commands.t @ 35428:71427ff1dff8
workers: handling exceptions in windows workers
This adds handling of exceptions from worker threads and resurfaces them as if the function ran without workers.
If any of the threads throws, the main thread kills all running threads giving them 5 sec to handle the interruption and raises the first exception received.
We don't have to join threads if is_alive() is false
Test Plan:
Ran multiple updates/enable/disable sparse profile and things worked well
Ran test on CentOS- all tests passing on @ passed here
Added a forged exception into the worker code and got it properly resurfaced and the rest of workers killed: P58642088
PS C:\open\<repo>> ..\facebook-hg-rpms\build\hg\hg.exe --config extensions.fsmonitor=! sparse --enable-profile <profile>
updating [==> ] 1300/39166 1m57sException in thread Thread-3:
Traceback (most recent call last):
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\threading.py", line 801, in __bootstrap_inner
self.run()
File "C:\open\facebook-hg-rpms\build\hg\mercurial\worker.py", line 244, in run
raise e
Exception: Forged exception
Exception in thread Thread-2:
Traceback (most recent call last):
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\threading.py", line 801, in __bootstrap_inner
self.run()
File "C:\open\facebook-hg-rpms\build\hg\mercurial\worker.py", line 244, in run
raise e
Exception: Forged exception
<...>
Traceback (most recent call last):
File "C:\open\facebook-hg-rpms\build\hg\hgexe.py", line 41, in <module>
dispatch.run()
File "C:\open\facebook-hg-rpms\build\hg\mercurial\dispatch.py", line 85, in run
status = (dispatch(req) or 0) & 255
File "C:\open\facebook-hg-rpms\build\hg\mercurial\dispatch.py", line 173, in dispatch
ret = _runcatch(req)
File "C:\open\facebook-hg-rpms\build\hg\mercurial\dispatch.py", line 324, in _runcatch
return _callcatch(ui, _runcatchfunc)
File "C:\open\facebook-hg-rpms\build\hg\mercurial\dispatch.py", line 332, in _callcatch
return scmutil.callcatch(ui, func)
File "C:\open\facebook-hg-rpms\build\hg\mercurial\scmutil.py", line 154, in callcatch
return func()
File "C:\open\facebook-hg-rpms\build\hg\mercurial\dispatch.py", line 314, in _runcatchfunc
return _dispatch(req)
File "C:\open\facebook-hg-rpms\build\hg\mercurial\dispatch.py", line 951, in _dispatch
cmdpats, cmdoptions)
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\remotefilelog\__init__.py", line 415, in runcommand
return orig(lui, repo, *args, **kwargs)
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\hgext3rd\undo.py", line 118, in _runcommandwrapper
result = orig(lui, repo, cmd, fullargs, *args)
File "C:\open\facebook-hg-rpms\build\hg\hgext\journal.py", line 84, in runcommand
return orig(lui, repo, cmd, fullargs, *args)
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\hgext3rd\perftweaks.py", line 268, in _tracksparseprofiles
res = runcommand(lui, repo, *args)
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\hgext3rd\perftweaks.py", line 256, in _trackdirstatesizes
res = runcommand(lui, repo, *args)
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\hgext3rd\copytrace.py", line 144, in _runcommand
return orig(lui, repo, cmd, fullargs, ui, *args, **kwargs)
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\hgext3rd\fbamend\hiddenoverride.py", line 119, in runcommand
result = orig(lui, repo, cmd, fullargs, *args)
File "C:\open\facebook-hg-rpms\build\hg\mercurial\dispatch.py", line 712, in runcommand
ret = _runcommand(ui, options, cmd, d)
File "C:\open\facebook-hg-rpms\build\hg\mercurial\dispatch.py", line 959, in _runcommand
return cmdfunc()
File "C:\open\facebook-hg-rpms\build\hg\mercurial\dispatch.py", line 948, in <lambda>
d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
File "C:\open\facebook-hg-rpms\build\hg\mercurial\util.py", line 1183, in check
return func(*args, **kwargs)
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\hgext3rd\fbsparse.py", line 860, in sparse
disableprofile=disableprofile, force=force)
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\hgext3rd\fbsparse.py", line 949, in _config
len, _refresh(ui, repo, oldstatus, oldsparsematch, force))
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\hgext3rd\fbsparse.py", line 1116, in _refresh
mergemod.applyupdates(repo, typeactions, repo[None], repo['.'], False)
File "C:\open\facebook-hg-rpms\build\hg\hg-python\lib\site-packages\remotefilelog\__init__.py", line 311, in applyupdates
return orig(repo, actions, wctx, mctx, overwrite, labels=labels)
File "C:\open\facebook-hg-rpms\build\hg\mercurial\merge.py", line 1464, in applyupdates
for i, item in prog:
File "C:\open\facebook-hg-rpms\build\hg\mercurial\worker.py", line 286, in _windowsworker
raise t.exception
Exception: Forged exception
PS C:\open\ovrsource>
Differential Revision: https://phab.mercurial-scm.org/D1459
author | Wojciech Lis <wlis@fb.com> |
---|---|
date | Mon, 20 Nov 2017 10:27:41 -0800 |
parents | 7fed389f9a9f |
children | 1b8238f67bf2 |
line wrap: on
line source
#require py3exe This test helps in keeping a track on which commands we can run on Python 3 and see what kind of errors are coming up. The full traceback is hidden to have a stable output. $ HGBIN=`which hg` $ for cmd in version debuginstall ; do > echo $cmd > $PYTHON3 $HGBIN $cmd 2>&1 2>&1 | tail -1 > done version warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. debuginstall no problems detected #if test-repo Make a clone so that any features in the developer's .hg/hgrc that might confuse Python 3 don't break this test. When we can do commit in Python 3, we'll stop doing this. We use e76ed1e480ef for the clone because it has different files than 273ce12ad8f1, so we can test both `files` from dirstate and `files` loaded from a specific revision. $ hg clone -r e76ed1e480ef "`dirname "$TESTDIR"`" testrepo 2>&1 | tail -1 15 files updated, 0 files merged, 0 files removed, 0 files unresolved Test using -R, which exercises some URL code: $ $PYTHON3 $HGBIN -R testrepo files -r 273ce12ad8f1 | tail -1 testrepo/tkmerge Now prove `hg files` is reading the whole manifest. We have to grep out some potential warnings that come from hgrc as yet. $ cd testrepo $ $PYTHON3 $HGBIN files -r 273ce12ad8f1 .hgignore PKG-INFO README hg mercurial/__init__.py mercurial/byterange.py mercurial/fancyopts.py mercurial/hg.py mercurial/mdiff.py mercurial/revlog.py mercurial/transaction.py notes.txt setup.py tkmerge $ $PYTHON3 $HGBIN files -r 273ce12ad8f1 | wc -l \s*14 (re) $ $PYTHON3 $HGBIN files | wc -l \s*15 (re) Test if log-like commands work: $ $PYTHON3 $HGBIN tip changeset: 10:e76ed1e480ef tag: tip user: oxymoron@cinder.waste.org date: Tue May 03 23:37:43 2005 -0800 summary: Fix linking of changeset revs when merging $ $PYTHON3 $HGBIN log -r0 changeset: 0:9117c6561b0b user: mpm@selenic.com date: Tue May 03 13:16:10 2005 -0800 summary: Add back links from file revisions to changeset revisions $ cd .. #endif Test if `hg config` works: $ $PYTHON3 $HGBIN config devel.all-warnings=true devel.default-date=0 0 largefiles.usercache=$TESTTMP/.cache/largefiles ui.slash=True ui.interactive=False ui.mergemarkers=detailed ui.promptecho=True web.address=localhost web.ipv6=False $ cat > included-hgrc <<EOF > [extensions] > babar = imaginary_elephant > EOF $ cat >> $HGRCPATH <<EOF > %include $TESTTMP/included-hgrc > EOF $ $PYTHON3 $HGBIN version | tail -1 *** failed to import extension babar from imaginary_elephant: *: 'imaginary_elephant' (glob) warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ rm included-hgrc $ touch included-hgrc Test bytes-ness of policy.policy with HGMODULEPOLICY $ HGMODULEPOLICY=py $ export HGMODULEPOLICY $ $PYTHON3 `which hg` debuginstall 2>&1 2>&1 | tail -1 no problems detected `hg init` can create empty repos `hg status works fine` `hg summary` also works! $ $PYTHON3 `which hg` init py3repo $ cd py3repo $ echo "This is the file 'iota'." > iota $ $PYTHON3 $HGBIN status ? iota $ $PYTHON3 $HGBIN add iota $ $PYTHON3 $HGBIN status A iota $ hg diff --nodates --git diff --git a/iota b/iota new file mode 100644 --- /dev/null +++ b/iota @@ -0,0 +1,1 @@ +This is the file 'iota'. $ $PYTHON3 $HGBIN commit --message 'commit performed in Python 3' $ $PYTHON3 $HGBIN status $ mkdir A $ echo "This is the file 'mu'." > A/mu $ $PYTHON3 $HGBIN addremove adding A/mu $ $PYTHON3 $HGBIN status A A/mu $ HGEDITOR='echo message > ' $PYTHON3 $HGBIN commit $ $PYTHON3 $HGBIN status $ $PYHON3 $HGBIN summary parent: 1:e1e9167203d4 tip message branch: default commit: (clean) update: (current) phases: 2 draft Test weird unicode-vs-bytes stuff $ $PYTHON3 $HGBIN help | egrep -v '^ |^$' Mercurial Distributed SCM list of commands: additional help topics: (use 'hg help -v' to show built-in aliases and global options) $ $PYTHON3 $HGBIN help help | egrep -v '^ |^$' hg help [-ecks] [TOPIC] show help for a given topic or a help overview options ([+] can be repeated): (some details hidden, use --verbose to show complete help) $ $PYTHON3 $HGBIN help -k notopic abort: no matches (try 'hg help' for a list of topics) [255] Prove the repo is valid using the Python 2 `hg`: $ hg verify checking changesets checking manifests crosschecking files in changesets and manifests checking files 2 files, 2 changesets, 2 total revisions $ hg log changeset: 1:e1e9167203d4 tag: tip user: test date: Thu Jan 01 00:00:00 1970 +0000 summary: message changeset: 0:71c96e924262 user: test date: Thu Jan 01 00:00:00 1970 +0000 summary: commit performed in Python 3 $ $PYTHON3 $HGBIN log -G @ changeset: 1:e1e9167203d4 | tag: tip | user: test | date: Thu Jan 01 00:00:00 1970 +0000 | summary: message | o changeset: 0:71c96e924262 user: test date: Thu Jan 01 00:00:00 1970 +0000 summary: commit performed in Python 3 $ $PYTHON3 $HGBIN log -Tjson [ { "rev": 1, "node": "e1e9167203d450ca2f558af628955b5f5afd4489", "branch": "default", "phase": "draft", "user": "test", "date": [0, 0], "desc": "message", "bookmarks": [], "tags": ["tip"], "parents": ["71c96e924262969ff0d8d3d695b0f75412ccc3d8"] }, { "rev": 0, "node": "71c96e924262969ff0d8d3d695b0f75412ccc3d8", "branch": "default", "phase": "draft", "user": "test", "date": [0, 0], "desc": "commit performed in Python 3", "bookmarks": [], "tags": [], "parents": ["0000000000000000000000000000000000000000"] } ] Show that update works now! $ $PYTHON3 $HGBIN up 0 0 files updated, 0 files merged, 1 files removed, 0 files unresolved $ $PYTHON3 $HGBIN identify 71c96e924262 branches and bookmarks also works! $ $PYTHON3 $HGBIN branches default 1:e1e9167203d4 $ $PYTHON3 $HGBIN bookmark book $ $PYTHON3 $HGBIN bookmarks * book 0:71c96e924262